fix(useChains): fix missing endpoints & chain name crash #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @pyramation |
pyramation
reviewed
Jan 31, 2025
| @@ -1,4 +1,5 @@ | |||
| import { AssetList, Chain } from '@chain-registry/types'; | |||
| import { chains } from 'chain-registry'; | |||
There was a problem hiding this comment.
sorry — we shouldn't be loading in the full blown chain-registry like this, is is already doing that or is this new?
There was a problem hiding this comment.
Hey, loading chains from chain-registry is new here. The reason for this change is that the bug being fixed occurs when a user passes only chain names to the chain provider instead of the full chains object from chain-registry. As a result, this file doesn’t have the necessary chain data. To resolve this, I loaded chain-registry to retrieve the chain data.
If you have any suggestions for improvement or know of alternative ways to fix this, please let me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Fix:
useChainsHook IssuesThis PR fixes two issues related to the
useChainshook in CosmosKit:Community Chains RPC/REST Error
useChainswith community chains would throw an error due to missing RPC or REST API endpoints inchainRecords.preferredEndpoints.example-liteproject.'ethereum','rootstock','solana','ton','tron','bluechip','lorenzo','neura','paloma','unicorn'.Crash When Using Chain Names in
ChainProvider🔗 Fixes:Uncaught TypeError: Cannot read properties of undefined (reading 'chain_id')when usinguseChains#515ChainProvidercaused a crash.convertChainreturningundefinedwhen receiving a chain name instead of a chain object, resulting in an emptychaininchainRecord.